Commit graph

397 commits

Author SHA1 Message Date
Matt
21c4a8539f Change websocket import location 2021-05-02 16:52:48 -04:00
Matt
979c077231 Move websocket to a dependency 2021-05-02 16:52:41 -04:00
Matt
be518f845b Make sure sync libraries are formatted properly 2021-05-02 12:56:32 -04:00
Matt
8b89ff3deb Make sure we only sync boxsets once 2021-05-02 12:46:47 -04:00
Matt
37a72759cb Fix removing music libraries 2021-04-30 20:55:07 -04:00
Matt
a1f3d8eb10 Fix followup sync again 2021-04-30 20:54:52 -04:00
venomousZealot
97a44985e6
Use jellyfin's DisplayTitle for audio and subtitle streams 2021-04-28 14:43:48 +02:00
mcarlton00
0a02ae69b1
Merge pull request #504 from venomousZealot/patch-1
Fix transcoding of wrong audio channel
2021-04-27 19:48:27 -04:00
Matt
5ec70bacbf Fix max bitrate profile, default to 1000Mbps 2021-04-27 18:27:25 -04:00
venomousZealot
45b4cb428a
Fix transcoding of wrong audio channel
It's a zero based index, so if the first entry is not the default language, you can't ever select it.
Probably related to https://github.com/jellyfin/jellyfin-kodi/issues/265

PS: It's my first time messing with code on github. Sorry, if I didn't follow protocol correctly.
2021-04-26 11:30:24 +02:00
f9f1cccb97
Merge pull request #494 from mcarlton00/subsequent-syncs
Fix syncing libraries after initial sync is complete
2021-04-25 00:42:20 +02:00
mcarlton00
77dbe45a4a
Merge pull request #484 from mcarlton00/context-menu
Fix playback from context and info menus
2021-04-19 19:40:26 -04:00
mammo0
0359e0f80a fixed 'args' beiing provided as list for dict.get() method
before the people cache was never used, because the 'args' parameter in
the 'self._people_cache.get(args)' call was a list/tuple object; but the
people cache dictionary has only strings as keys
-> so there were always database queries for the persons which slowed
down the sync process


also renamed 'args' to 'name', because basically a person gets searched
only by its name (see queries.py)
2021-04-19 18:07:03 +02:00
mammo0
ce5a74c3a8 avoid creating of a Kodi database object for every item in the workers 2021-04-19 17:33:16 +02:00
Matt
bc47e93d1c Remove unneeded function 2021-04-16 17:47:32 -04:00
Matt
2fcef85029 Fix playback from context and info menus 2021-04-16 17:47:32 -04:00
Matt
a1a135d0ea Fix syncing libraries after initial sync is complete 2021-04-16 17:42:26 -04:00
Matt
33dfd0ee82 Fix capitalization of variable 2021-03-15 23:42:11 -04:00
Matt
94b3a3e0a0 Fix recently added albums in Kodi 19 2021-03-15 23:32:37 -04:00
mcarlton00
b3e88bbeb2
Merge pull request #488 from mcarlton00/pls-mr-linter
Fix formatting on multiline if statement
2021-03-14 21:40:28 -04:00
Matt
d3d4996d0d Split if statement evenly 2021-03-14 19:09:10 -04:00
Matt
f12b58406b Fix formatting on multiline if statement 2021-03-14 09:50:19 -04:00
Matt
77f06b0817 Fix full syncs with new actors 2021-03-14 09:44:36 -04:00
Abby
96bdbefb8c
Merge pull request #485 from mcarlton00/people-sync
Fix integrity error in actor table during sync
2021-03-14 04:06:05 +00:00
Abby
cbe8860aad
Merge pull request #486 from mcarlton00/highest-db
Always use highest version database available
2021-03-14 02:25:31 +00:00
Matt
54a425fde4 Always use highest version database available 2021-03-13 21:13:44 -05:00
Matt
abf5b8b8df Remove unused import 2021-03-13 20:22:42 -05:00
Matt
2d60480df3 Rework people sync to avoid exception program flow 2021-03-13 20:13:40 -05:00
Matt
778dd43b3f Stop editing sources.xml 2021-03-08 20:12:52 -05:00
Matt
2ffe61de67 Disable the cleanonupdate tag in advancedsettings.xml 2021-02-25 22:13:30 -05:00
mcarlton00
01b114c19e
Merge pull request #475 from oddstr13/plural(s)
Fix: Get specific library vs list of libraries
2021-02-24 21:12:37 -05:00
9b30c883ea Fix import order 2021-02-23 02:53:10 +01:00
164fc50d98 Named tuples and type hints? What is this magic? 2021-02-23 02:42:26 +01:00
61fcfe3b5e Fix tuple prepend 2021-02-23 00:18:02 +01:00
2bade17e7f Why ever would I want the sync_id back when I query with it? 2021-02-22 05:31:25 +01:00
8517597262 Get specific library vs list of libraries 2021-02-22 04:42:51 +01:00
153396acbb array.array.tostring is removed in Python 3.9 2021-02-22 04:10:32 +01:00
Matt
0aa2e71320 Fix music artist syncing for Kodi 19 2021-01-23 22:20:34 -05:00
Matt
75590d3a1d Missing import 2021-01-23 22:20:34 -05:00
Matt
9d059a94d7 Fix casting 2021-01-23 22:20:34 -05:00
Matt
54270b2ebd Remove 'User' label from manual login forms 2021-01-23 22:19:57 -05:00
Matt
b094b7ba30 Fix boxset sync on startup, simplify code 2020-12-31 11:37:38 -05:00
mcarlton00
515f0a2978 Fix boxsets typo 2020-12-28 10:29:21 -05:00
mcarlton00
f536d68846 Remove commented line 2020-12-27 11:39:14 -05:00
mcarlton00
c8b524b2a9 Fix refresh boxsets function 2020-12-27 11:36:03 -05:00
mcarlton00
38ea9ba77c Remove extra slash from URLs in get_subtitles 2020-12-26 13:17:11 -05:00
084cf6f45d Encoding parameter to json.load was removed in Python 3.9 2020-12-21 19:27:42 +01:00
mcarlton00
a51fd6b932
Merge pull request #431 from oddstr13/pr-10.7-1
Fix some minor issues highlighted by 10.7
2020-12-20 18:57:49 -05:00
505a6dbe6d
Merge pull request #444 from mcarlton00/stop-overriding-my-server
Stop autodiscovered servers overriding manual input
2020-12-17 04:24:48 +01:00
64b0ed29e8
Merge pull request #446 from mcarlton00/no-crashy-on-skip
Fix crash on addon load
2020-12-17 04:22:49 +01:00
Matt
d1a66e00c3 Make sure status code gets returned in payload 2020-12-16 21:32:25 -05:00
Matt
49ce9e4359 Don't crash when a user skips server setup 2020-12-14 22:34:23 -05:00
Matt
ec59fb8cbe Stop overwriting manual input for reals this time 2020-12-12 23:21:46 -05:00
Matt
07313a38b8 Accept manual server input instead of looping 2020-12-12 13:17:06 -05:00
84fcecb2b3 Pass hexlify bytes in helper.utils.event
Fixes #441
2020-12-09 23:29:52 +01:00
Abby
f943316d25
Merge pull request #438 from mcarlton00/context-is-important
Move api_client details to context.py
2020-11-29 21:22:07 +00:00
Matt
203fb81f58 Move api_client details to context.py 2020-11-29 15:19:10 -05:00
9971940cac [websocket] Remove deprecated base64.encodestring
Clean up _validate_header a little bit
2020-11-29 19:25:49 +01:00
Abby Gourlay
8de6c30417 Fixing pipeline complaint about import order 2020-11-28 22:12:06 +00:00
Abby Gourlay
f0b0f551b6 Fixed dialog for deleting items + setup JellyfinClient for non-default entrypoints 2020-11-28 22:06:17 +00:00
146bd401bf HTTP 400: Log response body when it can't be decoded as json 2020-11-26 16:58:14 +01:00
8a9b69f2f5 Remove extra leading slash from the KodiSyncQueue ping endpoint 2020-11-26 16:58:14 +01:00
6c3b682ef0 Log HTTP 400 json payloads 2020-11-26 16:58:14 +01:00
a7e4fa8a5c
Merge pull request #425 from mcarlton00/BEGONE-SATAN
Remove TheVoid
2020-11-26 16:55:27 +01:00
Matt
bceeff4754 Fix missing apiclient on other PlayUtils actions 2020-11-23 20:41:32 -05:00
Matt
a3ce3ae4fa Fix voidless intros 2020-11-23 20:38:24 -05:00
Matt
22340e4e30 Create mysterious missing directory 2020-11-23 20:30:02 -05:00
Matt
144f71e71f Remove verify_kodi_defaults function 2020-11-18 19:36:41 -05:00
Matt
e487163ca2 Make the linter happy 2020-11-17 19:23:40 -05:00
Matt
bf4c385283 Fix fanart 2020-11-17 19:06:24 -05:00
Matt
feea23e9da Voidless playback. Slightly important 2020-11-17 12:10:04 -05:00
Matt
4a437f7a2b Make addon menu work without TheVoid 2020-11-17 11:01:55 -05:00
cvium
b6e2d0bbf3 Remove unused import 2020-11-17 11:01:00 -05:00
cvium
21cf8bcb68 Fix some linting issues 2020-11-17 11:01:00 -05:00
cvium
096680bc57 Remove unneeded import 2020-11-17 11:01:00 -05:00
cvium
a009530434 Byebye TheVoid 2020-11-17 11:00:50 -05:00
020bd59766 Fixes jellyfin/jellyfin-kodi#421
Jellyfin autodiscovery is IPv4 broadcast only.
We're not binding to a specific port, no need for SO_REUSEADDR.

IP_MULTICAST_LOOP belongs to IPPROTO_IP
https://tldp.org/HOWTO/Multicast-HOWTO-6.html
and SO_REUSEADDR belongs to SOL_SOCKET
https://docs.microsoft.com/en-us/windows/win32/winsock/sol-socket-socket-options
2020-11-15 18:50:54 +01:00
mcarlton00
711f2e1fcf
Merge pull request #417 from Electry/subs-extraction-fix
Don't force-extract subs for transcoded content
2020-11-04 22:45:31 -05:00
mammo0
dd7bca756a Merge branch 'master' into fix_for_#350 2020-11-02 09:55:46 +01:00
mammo0
5522c93458
set DTHREADS as semaphore size 2020-11-02 09:40:13 +01:00
Michal Chvíla
65b1704365 playutils: Show embedded subs in sub track selection dialog
* show embedded subtitles in subtitle track selection dialog when transcoding
  if server subtitle extraction is enabled
2020-10-29 16:11:56 +01:00
Michal Chvíla
fd93723968 playutils: Honor EnableSubtitleExtraction server option
* fix bug where subtitle streams that don't support external streaming
  would show up in video player OSD selection as external when transcoding
  (e.g. embedded PGSSUB)
* fix bug where EnableSubtitleExtraction server setting wasn't taken
  into consideration when transcoding
2020-10-28 11:45:43 +01:00
ccdcf27ec4
Merge pull request #412 from mcarlton00/quit-yelling-at-me
Fix db error messages on startup
2020-10-20 22:50:43 +02:00
macearl
5ce1b7d3e6 move LIMIT/DTHREADS into function _get_items to allow for on the fly changes without a restart or reboot 2020-10-19 19:52:06 +02:00
Matt
70160d2bb8 Fix db error messages on startup 2020-10-17 20:15:53 -04:00
mammo0
e510097193 re-added empty line to pass validation checks 2020-10-14 18:06:28 +02:00
mammo0
37281f6ca7 free memory after a thread completes
-> prior all threads that fetched items from the server and their
results stayed in memory until the sync was finished
2020-10-14 18:02:06 +02:00
mammo0
09b0bdbc48 use a semaphore to avoid fetching complete library to memory
-> this happens if the processing of items is slower as the fetching of
new
-> if a big library is synced, the old behavior could lead to extensive
use of memory
-> the semaphore acts like a buffer that only allows fetching of new
items from the library if old ones are processed
-> the current size of the 'buffer' is hard coded to 2 * [max. item
fetch limit] * [number of download threads]
2020-10-14 08:24:37 +02:00
mcarlton00
144c056641
Merge pull request #395 from Electry/master
Add more transcoding options
2020-10-04 11:25:07 -04:00
mcarlton00
00ba67772d
Merge pull request #403 from oddstr13/pr-flake8-2
Fix flake8 lints
2020-10-03 22:33:36 -04:00
b5404f992e
Merge pull request #401 from Electry/low-res-artwork-option
Add an option to reduce max artwork resolution
2020-09-29 02:48:00 +02:00
6d61a83b54 Flake8 linting 2020-09-27 04:20:24 +02:00
Michal Chvíla
204f50fa2e settings: Add an option to reduce max artwork resolution 2020-09-24 17:49:31 +02:00
Michal Chvíla
0fc908ec85 settings: Add an option to transcode VC-1 2020-09-24 17:41:09 +02:00
mcarlton00
3200c42432
Merge pull request #399 from bsdf/master
Fix extracted subtitle delivery for transcodes
2020-09-20 15:16:51 -04:00
BEN ENGLISCH
60ea47630b Fix extracted subtitle delivery for transcodes 2020-09-17 09:09:21 -05:00
David Francos
ad941ae483 fix: #396 Using kodi_version to determine loglevel 2020-09-17 10:38:22 +02:00
David Francos
cf1ee30e18 fix: #396 Brough back kodi 18 lognotice compat.
Kodi 18 seems to not log LOGINFO messages, this approach uses LOGNOTICE if its
available and LOGINFO otherwise, ensuring compatibility without needing to
check for kodi versions
2020-09-17 10:29:53 +02:00
David Francos
8ebee6e6de fix: #396 Kodi's LOGNOTICE loglevel is deprecated
KODI recenly deprecated LOGNOTICE (as per
https://github.com/xbmc/xbmc/pull/18346) and announced that LOGINFO should be
used instead.

LOGINFO has been available since kodi matrix's migration to spdlog in april
2020.
2020-09-17 00:51:46 +02:00
Michal Chvíla
fea6fc4cf1 playutils: Always honor manual transcoding bitrates
* Override VideoBitrate option in transcoding url (previously calced in backend)
* Use manual AudioBitrate when user has track selection dialog disabled
* Fix bad loop-and-remove
2020-09-15 01:33:44 +02:00
Michal Chvíla
e651b66ddc Add more transcoding options
* Redo max. bitrate options, add more bitrates in the lower end
* Remove SD/HD from the bitrate strings as the quality doesn't match up to what the backend selects (e.g. 1.3 Mbps definitely wasn't HD)
* Add option to force transcode mpeg2
* Add option to choose between h264 & h265 as a preferred codec for transcoding
* Add option to select preferred audio codec for transcoding/directstream
* Add option to select audio bitrate when transcoding (previously hardcoded to 384kbps for >2.0ch & 192kbps for <=2.0ch)
* Add option to select max audio channels (e.g. for server-side downmix)
* Add option to hide embedded/internal & picture-based subtitles in the track selection dialog
2020-09-15 00:30:23 +02:00
Michal Chvíla
4312135524 playutils: Prettify audio/subs track selection dialog
* Capitalize language in the track title
* Capitalize channel layout in the track title (e.g. 'Stereo')
* Remove track index from the title - users generally don't care what
the # is
* Use commercial names for the audio codecs (e.g. 'Dolby Digital'
instead of 'ac3')
* Always show codec name for subtitle tracks
2020-09-15 00:26:16 +02:00
Matt
813ec68e38 Review suggestions 2020-09-09 18:33:47 -04:00
Matt
c44a079572 remove commented variable 2020-09-07 22:47:10 -04:00
Matt
983c208415 Remove unused functions 2020-09-07 22:33:21 -04:00
Matt
db6cad8e15 Optimize music library lookups for larger libraries 2020-09-07 22:26:36 -04:00
6c5956d9bc Normalize path for os.mkdir
It's not happy with `foo/.`
2020-09-04 23:02:26 +02:00
holow29
b6ca78031c
Add BDMV and DVD Rip support in TV Shows
Porting @YK-Samgo's work from Movies.py to TVShows.py
2020-09-04 09:58:24 -04:00
ee7672a0a1 Handle empty files in profile video XMLs 2020-09-03 22:36:34 +02:00
7884ac4d88 Temporary workaround for #370 2020-08-25 01:53:46 +02:00
mcarlton00
4e2c8a0af3
Merge pull request #366 from oddstr13/pr-json-filter-1
Filter keys containing None values from dictionaries returned from the server
2020-08-21 17:43:52 -04:00
ed96dc8ad5 Clean json returned from server for keys with None values
Add testing
2020-08-21 15:09:34 +02:00
8a3ca73d52 flake8 2020-08-21 14:56:15 +02:00
8b1b648dfa
Merge pull request #362 from mcarlton00/might've-used-too-much
Refactor metadata ancestor gathering
2020-08-18 20:02:41 +02:00
mcarlton00
a4f9db249d
Update jellyfin_kodi/library.py
Co-authored-by: Odd Stråbø <oddstr13@openshell.no>
2020-08-18 14:01:23 -04:00
Matt
bbcc194018 Add libraryid to albums and songs in database 2020-08-15 00:03:45 -04:00
Matt
d3d5c46c60 pass exception through to calling function 2020-08-15 00:03:34 -04:00
Matt
ae0dbc0400 Refactor where the ancestor check takes place 2020-08-15 00:02:00 -04:00
Abby Gourlay
ebcbd1893f Removed webservice 2020-08-15 01:04:57 +01:00
Matt
75ac8ef1b8 Don't find ancestors on userdata updates 2020-08-12 21:04:05 -04:00
mcarlton00
2dff3a96ef
Merge pull request #359 from TrueTechy/because-why-not
SSL Verification Fix
2020-08-10 09:10:44 -04:00
Abby Gourlay
a1a318d636 SSL Verification Fix 2020-08-10 12:38:24 +01:00
“Tyler
ebf8a1a903 Remove whitespace in setup xbmcgui dialogs 2020-08-08 21:46:51 -07:00
a4d2dad11e Use libraries rather than home-screen views 2020-08-06 23:18:44 +02:00
a2d0c3cb49 Remove Ancestor found debug (info) log 2020-08-06 03:44:55 +02:00
70ef07276a Fix UserDataWorker 2020-08-06 02:31:38 +02:00
16bd0091f7
Merge pull request #348 from TrueTechy/fix/sonarqube-clumsy
Various fixes from sonarqube
2020-08-05 22:45:11 +02:00
Matt
d10ca845f4 empty default if there are no boxsets in the server 2020-08-03 15:07:26 -04:00
Matt
ce21b37501 Remove unneeded message variable 2020-08-03 14:37:49 -04:00
Matt
dc6c9e7dc2 Fix code smells for unused variables 2020-08-02 19:15:59 -04:00
Matt
7f012dc8b0 Fix undefined variable in remove function 2020-08-02 19:12:15 -04:00
Matt
4178f0a362 Fix boxset syncing 2020-08-02 18:50:57 -04:00
Matt
eca9630918 Remove library_check wrapper 2020-08-02 17:00:34 -04:00
Abby
12dee0b61c
Added space 2020-08-02 17:50:56 +01:00
Abby Gourlay
da6c754d90 Remove unused dict 2020-08-02 16:06:04 +01:00
Abby Gourlay
cc899931ed Removed else statements from loops without breaks 2020-08-02 15:53:58 +01:00
Abby Gourlay
98c86304fe Removed sonarqube issues tagged clumsy 2020-08-02 15:46:32 +01:00
Matt
0ee5b616a5 stupid getitems 2020-08-02 09:43:12 -04:00
Matt
2c55f7a27c Remove library_check wrapper from songs 2020-08-02 09:43:02 -04:00
Matt
5f34222712 Optimize network calls for music syncing 2020-08-02 09:42:16 -04:00
mcarlton00
da21f49928
Merge pull request #345 from oddstr13/pr-cleanup-1
A tiny bit of code cleanup
2020-08-02 09:31:32 -04:00
50e514459c Replace commented code with docstring 2020-08-02 15:07:11 +02:00
f8c277a2c3 Remove some excessively verbose debug logging 2020-08-02 14:59:46 +02:00
mcarlton00
96d5b61c7c
Merge pull request #346 from TrueTechy/fix/start-over
Get resume from Kodi arguments
2020-07-31 23:08:47 -04:00
Abby Gourlay
d8a7e43070 Fixed playback time selection for forced transcodes 2020-08-01 00:14:31 +01:00
Abby Gourlay
6f00779d73 Get resume from Kodi arguments 2020-07-31 23:53:12 +01:00
8b1c0bd1e4 Nuke catch and silent_catch decorators from orbit 2020-08-01 00:09:22 +02:00
3ec71e89d6 Refractor some decorators 2020-08-01 00:09:22 +02:00
803081f65a Remove some generic exceptions 2020-08-01 00:08:03 +02:00
e543762483 Fix music sync 2020-07-31 22:22:23 +02:00