Commit graph

109 commits

Author SHA1 Message Date
mcarlton00
0a02ae69b1
Merge pull request #504 from venomousZealot/patch-1
Fix transcoding of wrong audio channel
2021-04-27 19:48:27 -04:00
Matt
5ec70bacbf Fix max bitrate profile, default to 1000Mbps 2021-04-27 18:27:25 -04:00
venomousZealot
45b4cb428a
Fix transcoding of wrong audio channel
It's a zero based index, so if the first entry is not the default language, you can't ever select it.
Probably related to https://github.com/jellyfin/jellyfin-kodi/issues/265

PS: It's my first time messing with code on github. Sorry, if I didn't follow protocol correctly.
2021-04-26 11:30:24 +02:00
Matt
778dd43b3f Stop editing sources.xml 2021-03-08 20:12:52 -05:00
Matt
2ffe61de67 Disable the cleanonupdate tag in advancedsettings.xml 2021-02-25 22:13:30 -05:00
mcarlton00
38ea9ba77c Remove extra slash from URLs in get_subtitles 2020-12-26 13:17:11 -05:00
84fcecb2b3 Pass hexlify bytes in helper.utils.event
Fixes #441
2020-12-09 23:29:52 +01:00
Matt
feea23e9da Voidless playback. Slightly important 2020-11-17 12:10:04 -05:00
cvium
a009530434 Byebye TheVoid 2020-11-17 11:00:50 -05:00
Michal Chvíla
65b1704365 playutils: Show embedded subs in sub track selection dialog
* show embedded subtitles in subtitle track selection dialog when transcoding
  if server subtitle extraction is enabled
2020-10-29 16:11:56 +01:00
Michal Chvíla
fd93723968 playutils: Honor EnableSubtitleExtraction server option
* fix bug where subtitle streams that don't support external streaming
  would show up in video player OSD selection as external when transcoding
  (e.g. embedded PGSSUB)
* fix bug where EnableSubtitleExtraction server setting wasn't taken
  into consideration when transcoding
2020-10-28 11:45:43 +01:00
mcarlton00
144c056641
Merge pull request #395 from Electry/master
Add more transcoding options
2020-10-04 11:25:07 -04:00
mcarlton00
00ba67772d
Merge pull request #403 from oddstr13/pr-flake8-2
Fix flake8 lints
2020-10-03 22:33:36 -04:00
b5404f992e
Merge pull request #401 from Electry/low-res-artwork-option
Add an option to reduce max artwork resolution
2020-09-29 02:48:00 +02:00
6d61a83b54 Flake8 linting 2020-09-27 04:20:24 +02:00
Michal Chvíla
204f50fa2e settings: Add an option to reduce max artwork resolution 2020-09-24 17:49:31 +02:00
Michal Chvíla
0fc908ec85 settings: Add an option to transcode VC-1 2020-09-24 17:41:09 +02:00
mcarlton00
3200c42432
Merge pull request #399 from bsdf/master
Fix extracted subtitle delivery for transcodes
2020-09-20 15:16:51 -04:00
BEN ENGLISCH
60ea47630b Fix extracted subtitle delivery for transcodes 2020-09-17 09:09:21 -05:00
David Francos
ad941ae483 fix: #396 Using kodi_version to determine loglevel 2020-09-17 10:38:22 +02:00
David Francos
cf1ee30e18 fix: #396 Brough back kodi 18 lognotice compat.
Kodi 18 seems to not log LOGINFO messages, this approach uses LOGNOTICE if its
available and LOGINFO otherwise, ensuring compatibility without needing to
check for kodi versions
2020-09-17 10:29:53 +02:00
David Francos
8ebee6e6de fix: #396 Kodi's LOGNOTICE loglevel is deprecated
KODI recenly deprecated LOGNOTICE (as per
https://github.com/xbmc/xbmc/pull/18346) and announced that LOGINFO should be
used instead.

LOGINFO has been available since kodi matrix's migration to spdlog in april
2020.
2020-09-17 00:51:46 +02:00
Michal Chvíla
fea6fc4cf1 playutils: Always honor manual transcoding bitrates
* Override VideoBitrate option in transcoding url (previously calced in backend)
* Use manual AudioBitrate when user has track selection dialog disabled
* Fix bad loop-and-remove
2020-09-15 01:33:44 +02:00
Michal Chvíla
e651b66ddc Add more transcoding options
* Redo max. bitrate options, add more bitrates in the lower end
* Remove SD/HD from the bitrate strings as the quality doesn't match up to what the backend selects (e.g. 1.3 Mbps definitely wasn't HD)
* Add option to force transcode mpeg2
* Add option to choose between h264 & h265 as a preferred codec for transcoding
* Add option to select preferred audio codec for transcoding/directstream
* Add option to select audio bitrate when transcoding (previously hardcoded to 384kbps for >2.0ch & 192kbps for <=2.0ch)
* Add option to select max audio channels (e.g. for server-side downmix)
* Add option to hide embedded/internal & picture-based subtitles in the track selection dialog
2020-09-15 00:30:23 +02:00
Michal Chvíla
4312135524 playutils: Prettify audio/subs track selection dialog
* Capitalize language in the track title
* Capitalize channel layout in the track title (e.g. 'Stereo')
* Remove track index from the title - users generally don't care what
the # is
* Use commercial names for the audio codecs (e.g. 'Dolby Digital'
instead of 'ac3')
* Always show codec name for subtitle tracks
2020-09-15 00:26:16 +02:00
a2d0c3cb49 Remove Ancestor found debug (info) log 2020-08-06 03:44:55 +02:00
16bd0091f7
Merge pull request #348 from TrueTechy/fix/sonarqube-clumsy
Various fixes from sonarqube
2020-08-05 22:45:11 +02:00
Matt
eca9630918 Remove library_check wrapper 2020-08-02 17:00:34 -04:00
Abby
12dee0b61c
Added space 2020-08-02 17:50:56 +01:00
Abby Gourlay
98c86304fe Removed sonarqube issues tagged clumsy 2020-08-02 15:46:32 +01:00
50e514459c Replace commented code with docstring 2020-08-02 15:07:11 +02:00
f8c277a2c3 Remove some excessively verbose debug logging 2020-08-02 14:59:46 +02:00
8b1c0bd1e4 Nuke catch and silent_catch decorators from orbit 2020-08-01 00:09:22 +02:00
3ec71e89d6 Refractor some decorators 2020-08-01 00:09:22 +02:00
803081f65a Remove some generic exceptions 2020-08-01 00:08:03 +02:00
yk
eb265d7a13 add dvd directry support 2020-07-07 22:52:23 +02:00
yk
1e7b875dbe remove useless code and change one logging debug text 2020-06-27 22:45:39 +08:00
yk
70d7522570 add support for BDMV movies in the bluray directry by pointing the file to ./BDMV/index.bdmv 2020-06-27 21:28:27 +08:00
Matt
eb34578488 Sanitize the server URL in log messages 2020-06-09 19:53:32 -04:00
db51abd786 Add Kodi 17 backwards compat to #308 2020-05-31 01:07:16 +02:00
a6241d25db Update deprecated isPassword functionality
and dialog line1 to message parameter rename.

The isPassword change likely bumps minimum version up to Kodi 18.
This can be worked around if desirable.
2020-05-29 01:11:25 +02:00
b67f7a8c51 Handle sys.getfilesystemencoding() returning None 2020-04-21 12:48:30 +02:00
5bd08635f2 Make sure file paths is text, not binary
Work around https://bugs.python.org/issue6543 for Python 2
2020-04-20 20:20:17 +02:00
3f63e7c213 Fix linting, flake8 and sonarcloud issues 2020-04-19 12:07:55 +02:00
6c5ac6292d Overwriting logging.Formatter._fmt seems to
no longer work in Python 3
2020-04-19 04:37:58 +02:00
795dfd38df Get the logger from a central place 2020-04-19 03:21:40 +02:00
a9793eb1c9 Update deprecated kodi api functions 2020-04-02 15:49:22 +02:00
Abby Gourlay
2cef5b727f Moved setting addon mode to utils
It was the only useful function left in setup.py since we've removed the rest of them over time
2020-03-30 02:48:09 +01:00
Matt
fcc6e942ab Use correct xml library for kodi 2020-03-07 08:36:30 -05:00
Matt
bb0a539074 Rework xml unicode handling 2020-03-06 23:38:43 -05:00
Matt
7efc6f9b6a Fix variable names 2020-02-25 20:25:47 -05:00
Matt
1d02fccce6 Prevent harmless errors about bad dates from the server 2020-02-25 20:19:59 -05:00
Chuddah
de493d13dd Moved JsonDebugPrinter to existing utils module 2020-02-22 15:04:28 +00:00
Chuddah
7491000a13 Replaced debug output of json.dumps with an indirection to lazy __str__.
json.dumps is a processing intensive operation. This is being called
every time data is received from the server (most noticeably during
library updates) for debug logging. If the user has debug logging
disabled (the default option) then the user is still paying for
processing which is discarded.

The fix is to add a level of indirection where the dumps function is
only called if a string representation of the json is requested; ie.
when the debug string is evaluated.
2020-02-16 22:17:05 +00:00
Odd Stråbø
933a31ac23 Fixes for Kodi 18.5 (and Python2) 2020-01-04 05:17:51 +01:00
a51bf9c2cc Initial work on Kodi 19 (and Python 3) support 2020-01-04 03:32:30 +01:00
mcarlton00
a7c96577cd Remove all emby api endpoints 2019-12-14 08:19:57 -05:00
TrueTechy
4e179890ec Change translation function name from _ to translate 2019-11-25 00:58:44 +00:00
TrueTechy
84b8093171 Begin restructing, fixed some issues related to movement 2019-11-07 22:58:44 +01:00