Commit Graph

26 Commits

Author SHA1 Message Date
venomousZealot e907e35773
Fix impossibility of choosing the first subtitle
The usual combination of a zero-based index and a lazy if...

Also, there is no reason to use the default subtitles after asking users which subtitles they want.
2021-05-17 16:39:46 +02:00
venomousZealot 8870d772a8
Remove unused import 2021-05-05 14:23:26 +02:00
venomousZealot c79980c477
Make sonarcloud happy 2021-05-05 14:08:48 +02:00
venomousZealot 1ae54a3e20
Additional cleanup 2021-05-05 14:05:27 +02:00
venomousZealot 46d16293d2
Replacing ordered dictionaries with lists
Allows multiple subtitles with identical names. Should fix https://github.com/jellyfin/jellyfin-kodi/issues/435
2021-05-05 13:53:30 +02:00
venomousZealot 97a44985e6
Use jellyfin's DisplayTitle for audio and subtitle streams 2021-04-28 14:43:48 +02:00
mcarlton00 0a02ae69b1
Merge pull request #504 from venomousZealot/patch-1
Fix transcoding of wrong audio channel
2021-04-27 19:48:27 -04:00
Matt 5ec70bacbf Fix max bitrate profile, default to 1000Mbps 2021-04-27 18:27:25 -04:00
venomousZealot 45b4cb428a
Fix transcoding of wrong audio channel
It's a zero based index, so if the first entry is not the default language, you can't ever select it.
Probably related to https://github.com/jellyfin/jellyfin-kodi/issues/265

PS: It's my first time messing with code on github. Sorry, if I didn't follow protocol correctly.
2021-04-26 11:30:24 +02:00
mcarlton00 38ea9ba77c Remove extra slash from URLs in get_subtitles 2020-12-26 13:17:11 -05:00
Matt feea23e9da Voidless playback. Slightly important 2020-11-17 12:10:04 -05:00
cvium a009530434 Byebye TheVoid 2020-11-17 11:00:50 -05:00
Michal Chvíla 65b1704365 playutils: Show embedded subs in sub track selection dialog
* show embedded subtitles in subtitle track selection dialog when transcoding
  if server subtitle extraction is enabled
2020-10-29 16:11:56 +01:00
Michal Chvíla fd93723968 playutils: Honor EnableSubtitleExtraction server option
* fix bug where subtitle streams that don't support external streaming
  would show up in video player OSD selection as external when transcoding
  (e.g. embedded PGSSUB)
* fix bug where EnableSubtitleExtraction server setting wasn't taken
  into consideration when transcoding
2020-10-28 11:45:43 +01:00
mcarlton00 144c056641
Merge pull request #395 from Electry/master
Add more transcoding options
2020-10-04 11:25:07 -04:00
Michal Chvíla 0fc908ec85 settings: Add an option to transcode VC-1 2020-09-24 17:41:09 +02:00
BEN ENGLISCH 60ea47630b Fix extracted subtitle delivery for transcodes 2020-09-17 09:09:21 -05:00
Michal Chvíla fea6fc4cf1 playutils: Always honor manual transcoding bitrates
* Override VideoBitrate option in transcoding url (previously calced in backend)
* Use manual AudioBitrate when user has track selection dialog disabled
* Fix bad loop-and-remove
2020-09-15 01:33:44 +02:00
Michal Chvíla e651b66ddc Add more transcoding options
* Redo max. bitrate options, add more bitrates in the lower end
* Remove SD/HD from the bitrate strings as the quality doesn't match up to what the backend selects (e.g. 1.3 Mbps definitely wasn't HD)
* Add option to force transcode mpeg2
* Add option to choose between h264 & h265 as a preferred codec for transcoding
* Add option to select preferred audio codec for transcoding/directstream
* Add option to select audio bitrate when transcoding (previously hardcoded to 384kbps for >2.0ch & 192kbps for <=2.0ch)
* Add option to select max audio channels (e.g. for server-side downmix)
* Add option to hide embedded/internal & picture-based subtitles in the track selection dialog
2020-09-15 00:30:23 +02:00
Michal Chvíla 4312135524 playutils: Prettify audio/subs track selection dialog
* Capitalize language in the track title
* Capitalize channel layout in the track title (e.g. 'Stereo')
* Remove track index from the title - users generally don't care what
the # is
* Use commercial names for the audio codecs (e.g. 'Dolby Digital'
instead of 'ac3')
* Always show codec name for subtitle tracks
2020-09-15 00:26:16 +02:00
Odd Stråbø 3f63e7c213 Fix linting, flake8 and sonarcloud issues 2020-04-19 12:07:55 +02:00
Odd Stråbø 795dfd38df Get the logger from a central place 2020-04-19 03:21:40 +02:00
Odd Stråbø a51bf9c2cc Initial work on Kodi 19 (and Python 3) support 2020-01-04 03:32:30 +01:00
mcarlton00 a7c96577cd Remove all emby api endpoints 2019-12-14 08:19:57 -05:00
TrueTechy 4e179890ec Change translation function name from _ to translate 2019-11-25 00:58:44 +00:00
TrueTechy 84b8093171 Begin restructing, fixed some issues related to movement 2019-11-07 22:58:44 +01:00