Commit graph

97 commits

Author SHA1 Message Date
mcarlton00
1a83263095
Merge pull request #257 from TrueTechy/server_change_warning
Disabled changing server details & Removed corresponding function
2020-03-30 22:31:59 -04:00
Abby Gourlay
ab6e51af58 Disabled changing server settings in settings menu & Removed corresponding update info function 2020-03-30 03:08:57 +01:00
Abby
b37b903cca
Merge pull request #253 from mcarlton00/cleanup-remove-libraries
Remove MEDIA lookup dict
2020-03-29 22:45:11 +01:00
Matt
e414e28157 Simplify remove function calls 2020-03-28 23:37:07 -04:00
Matt
a96877f34d Fix typo 2020-03-28 23:27:08 -04:00
Matt
aeca1a0049 Cleanup code around removing libraries 2020-03-28 23:25:13 -04:00
Matt
dd57dff79f Don't encode strings that don't need it 2020-03-28 12:21:52 -04:00
mcarlton00
7d9b7dec7d
Merge pull request #249 from TrueTechy/fix-typo
Fixed typo introduced in #215
2020-03-26 14:54:46 -04:00
Abby Gourlay
936f1c6bc6 Fixed typo introduced in #215 2020-03-26 17:59:39 +00:00
Matt
43ee6991cb Remove duplicate strings in translations 2020-03-25 19:16:00 -04:00
Abby
57582d234f
Merge pull request #240 from mcarlton00/follow-redirects
Follow redirects when connecting to server
2020-03-23 00:29:39 +00:00
Matt
3e1884176d Give xml files correct attributes 2020-03-21 19:44:08 -04:00
3788a0b79c
Merge pull request #236 from mcarlton00/ascii-round-two
Fix ascii error on context menu
2020-03-21 18:20:58 +01:00
Matt
0647447c3c Follow redirects when connecting to server 2020-03-21 12:42:25 -04:00
Abby
69bb8bca04
Merge pull request #238 from mcarlton00/delete-artwork
Add ability to delete artwork from database
2020-03-20 23:41:08 +00:00
Matt
05a375d826 Add ability to delete artwork from database 2020-03-19 19:28:49 -04:00
Matt
4de1230cf5 Fix capitalization in boxsets 2020-03-19 18:04:23 -04:00
Matt
6e786a1e6b Use six to get correct string format 2020-03-19 12:37:50 -04:00
Matt
44808f5dd4 Fix ascii error on context menu 2020-03-19 09:37:47 -04:00
mcarlton00
d7364afbf5
Merge pull request #231 from TrueTechy/remove-webservice
Removed web server for image caching
2020-03-18 12:56:31 -04:00
mcarlton00
881c0e947a
Merge pull request #232 from TrueTechy/year-error-handling
Mitigation for #216 for invalid year
2020-03-17 21:33:45 -04:00
Abby Gourlay
9cb0f63749 Left an import in the clipboard 2020-03-18 01:20:22 +00:00
Abby Gourlay
1df9f15859 Resolved suggestions 2020-03-18 01:18:19 +00:00
mcarlton00
a7ef2f6243
Merge pull request #221 from TrueTechy/cleanup-connection-manager
Cleanup connection manager
2020-03-16 09:05:26 -04:00
Abby Gourlay
37a836dd57 Changed function return type 2020-03-16 12:36:06 +00:00
Abby Gourlay
5c93a06e9b Added mitigation for #216 for when the year data from the server is invalid 2020-03-15 01:27:07 +00:00
Abby Gourlay
3bff962cad Removed web server for image caching 2020-03-14 22:37:09 +00:00
Abby Gourlay
a044c1fd29 Fixed API parameter bad optimisation 2020-03-14 21:53:15 +00:00
Abby Gourlay
48ed8ad74c Implemented Suggestions 2020-03-12 22:20:18 +00:00
Abby Gourlay
068a842184 Removed profilling code accidentally commited 2020-03-08 18:08:30 +00:00
Abby Gourlay
36cd765c21 Updated debug logging for sanitising user data 2020-03-08 16:29:15 +00:00
Matt
0cff79e3c8 Fix logic around checking existing video directory 2020-03-07 10:12:49 -05:00
Matt
fcc6e942ab Use correct xml library for kodi 2020-03-07 08:36:30 -05:00
Matt
bb0a539074 Rework xml unicode handling 2020-03-06 23:38:43 -05:00
Abby Gourlay
298c8b6f25 Renamed function for better clarity 2020-03-06 22:57:13 +00:00
Abby
4806379a25
Merge pull request #209 from druscoe/reduce_execute_and_fetch_one_calls
Reduce execute and fetch one calls
2020-02-27 23:30:10 +00:00
Abby
e4a364e3bf
Merge pull request #215 from itsthejoker/library-clarifications
Remove duplicated code and rename UpdatedWorker class
2020-02-27 23:23:59 +00:00
Joe Kaufeld
12a373d030 remove duplicated code and rename UpdatedWorker class
Signed-off-by: Joe Kaufeld <joe@grafeas.org>
2020-02-26 22:49:42 -05:00
Matt
e6101b404a Fix music video scanning 2020-02-26 21:05:38 -05:00
Matt
de95807323 Run library updates properly with current items 2020-02-26 20:59:02 -05:00
Abby
43f0c57ffd
Merge pull request #211 from mcarlton00/once-more-with-feeling
More getitem cleanup in library
2020-02-26 23:07:12 +00:00
Matt
7efc6f9b6a Fix variable names 2020-02-25 20:25:47 -05:00
Matt
1d02fccce6 Prevent harmless errors about bad dates from the server 2020-02-25 20:19:59 -05:00
Matt
4e37aa9bbf Finish getitem cleanup in library 2020-02-25 18:39:50 -05:00
Chuddah
e23d2e1f7b Forgot to remove unexecuted code. 2020-02-23 19:31:41 +00:00
Chuddah
6fe450da4d Attempt number 2 on a larger dataset; the people table.
Note: This has a previously applied optimization of using a local cache.

Before:
```
458570   66.934    0.000   66.934    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
246771   58.075    0.000   58.075    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

After:
```
368883   66.220    0.000   66.220    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
157084   58.160    0.000   58.160    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

Once again, the number of calls to execute and fetchone are reduced but
the total time spent executing each is relatively stable.
2020-02-23 18:27:12 +00:00
Chuddah
0a69894320 Attempt to reduce the number of calls to execute and fetchone.
Profiling has shown that there are many calls to sqlite3.execute and
fetchone which takes a signicant amount of time. A simple way of
reducing these is to swap the 2-stage init of table row data into a
unified add.

Applying this to add_set and add_country yielded these results:

Before changes
```
281784    7.054    0.000    7.054    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
127443    1.114    0.000    1.114    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

After changes
```
281714    7.492    0.000    7.492    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
127373    1.217    0.000    1.217    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

Note: The total time of fetchone has actually increased. I am hoping
this was an abnormality on my machine and the actual reduction in the
number of calls will permantly reduce this total time.
2020-02-23 18:00:38 +00:00
Matt
19ec48cd5b Use six library instead of checking sys version 2020-02-23 00:07:44 -05:00
Matt
5479ba2775 Make commands python 2/3 compatible 2020-02-22 23:23:14 -05:00
mcarlton00
0e4458fa75
Merge pull request #193 from druscoe/inefficeint_usage_of_json_dumps_in_debug_output
Replaced debug output of json.dumps with an indirection to lazy __str__.
2020-02-22 14:50:49 -05:00