Commit graph

191 commits

Author SHA1 Message Date
yk
1e7b875dbe remove useless code and change one logging debug text 2020-06-27 22:45:39 +08:00
yk
70d7522570 add support for BDMV movies in the bluray directry by pointing the file to ./BDMV/index.bdmv 2020-06-27 21:28:27 +08:00
Luca Weiss
8ed3be521b Add support for music database format v74
See the following commit for reference:
  8fb8a640e0

Fixes #281
2020-06-17 22:19:00 +02:00
mcarlton00
15056cb146 Force filter parameter during incremental sync 2020-06-14 15:32:02 -04:00
Abby
f0bb8dfc3a
Merge pull request #310 from Lumenol/fix_change_audio_subtitle_stream_remotely
Fix choose the audio stream and the subtitle stream remotely
2020-06-11 01:47:43 +01:00
Matt
0ee8a1bd70 Add delay to playback reporting 2020-06-09 20:12:37 -04:00
Matt
eb34578488 Sanitize the server URL in log messages 2020-06-09 19:53:32 -04:00
Matt
f5460a79fe Fix incremental sync for mixed content libraries 2020-06-06 14:37:34 -04:00
db51abd786 Add Kodi 17 backwards compat to #308 2020-05-31 01:07:16 +02:00
Lumenol
84f111843c
Convert parameters to int if they are not None 2020-05-30 21:16:03 +02:00
mcarlton00
4e34537c5f
Merge pull request #308 from oddstr13/pr-kodi19-2
Update deprecated isPassword and line1 function parameters
2020-05-30 14:22:14 -04:00
981e05e2b9 Fix server selection list to show multiple servers 2020-05-29 01:22:10 +02:00
a6241d25db Update deprecated isPassword functionality
and dialog line1 to message parameter rename.

The isPassword change likely bumps minimum version up to Kodi 18.
This can be worked around if desirable.
2020-05-29 01:11:25 +02:00
Abby
60e80254ec
Merge pull request #305 from mcarlton00/incremental-sync
Only request updates for synced libraries
2020-05-26 13:21:48 +01:00
Matt
d6b68f44ea Only request updates for synced libraries 2020-05-25 22:14:50 -04:00
Abby
f1eec7a90a
Merge pull request #301 from mcarlton00/password-reset
Add reset password dialog to addon menu
2020-05-25 16:38:43 +01:00
Matt
9c11dbc113 Validate token returns dict no matter what 2020-05-24 16:26:39 -04:00
Matt
0f1f8be5ce Use utf-8 for header encoding 2020-05-23 10:11:37 -04:00
Matt
5cbc798cad Allow the device name to have unicode characters 2020-05-22 20:46:35 -04:00
Matt
de95d23e5a Catch bad passwords on addon startup 2020-05-22 18:55:21 -04:00
Matt
22b5d413fd Add reset password dialog to addon menu 2020-05-19 21:47:19 -04:00
mcarlton00
0f84d148b9 Don't sort playlist contents 2020-05-18 23:39:48 -04:00
Abby
4b679eab74
Merge pull request #297 from mcarlton00/addon-menu
Improve addon menu
2020-05-16 17:45:15 +01:00
Matt
14257f2a30 Only show playlists once 2020-05-15 19:15:01 -04:00
Matt
21dd8d95e8 Add music to addon menu 2020-05-15 19:07:45 -04:00
Matt
7911d957dc Fix errors before login occurs 2020-05-14 21:07:36 -04:00
Matt
19c69921c9 Report all items in a playlist 2020-04-25 16:05:57 -04:00
b67f7a8c51 Handle sys.getfilesystemencoding() returning None 2020-04-21 12:48:30 +02:00
5bd08635f2 Make sure file paths is text, not binary
Work around https://bugs.python.org/issue6543 for Python 2
2020-04-20 20:20:17 +02:00
0d4962ad83 sys.argv[1:] is not available in all addon threads 2020-04-19 13:08:00 +02:00
3f63e7c213 Fix linting, flake8 and sonarcloud issues 2020-04-19 12:07:55 +02:00
mcarlton00
87af711c94
Merge pull request #277 from oddstr13/pr-logging-2
Attempt to improve logging
2020-04-19 00:32:38 -04:00
0ba319e700 Use __name__ for all logger names 2020-04-19 06:13:25 +02:00
6c5ac6292d Overwriting logging.Formatter._fmt seems to
no longer work in Python 3
2020-04-19 04:37:58 +02:00
swedge
9ddab3fc9f Fixes #278 2020-04-18 21:39:26 -04:00
795dfd38df Get the logger from a central place 2020-04-19 03:21:40 +02:00
21643cd95e Disable TLSv1.0 and TLSv1.1 in websocket lib
These protocols are disabled by default in modern browsers
as of March/April 2020.
2020-04-16 03:37:34 +02:00
0dfea09769 Disable SSLv2 and SSLv3 support in websocket lib
Requires Python2 >= 2.7.9, Python3 >= 3.6
2020-04-16 01:57:13 +02:00
a9793eb1c9 Update deprecated kodi api functions 2020-04-02 15:49:22 +02:00
mcarlton00
38e151dc9a
Merge pull request #260 from TrueTechy/public_info_check
Added better error handling to public info check
2020-04-01 18:42:57 -04:00
Abby Gourlay
694c3ae3dd Added better error handling to public info check 2020-04-01 01:18:27 +01:00
mcarlton00
f4dc20cdf7
Merge pull request #256 from TrueTechy/remove_cachingQ_reset
Moved setting addon mode to utils
2020-03-30 23:26:46 -04:00
mcarlton00
1a83263095
Merge pull request #257 from TrueTechy/server_change_warning
Disabled changing server details & Removed corresponding function
2020-03-30 22:31:59 -04:00
Abby Gourlay
b4a2ee9d90 Added check to see if addon has already been setup 2020-03-30 17:43:41 +01:00
Abby Gourlay
ab6e51af58 Disabled changing server settings in settings menu & Removed corresponding update info function 2020-03-30 03:08:57 +01:00
Abby Gourlay
2cef5b727f Moved setting addon mode to utils
It was the only useful function left in setup.py since we've removed the rest of them over time
2020-03-30 02:48:09 +01:00
Abby
b37b903cca
Merge pull request #253 from mcarlton00/cleanup-remove-libraries
Remove MEDIA lookup dict
2020-03-29 22:45:11 +01:00
Matt
e414e28157 Simplify remove function calls 2020-03-28 23:37:07 -04:00
Matt
a96877f34d Fix typo 2020-03-28 23:27:08 -04:00
Matt
aeca1a0049 Cleanup code around removing libraries 2020-03-28 23:25:13 -04:00
Matt
dd57dff79f Don't encode strings that don't need it 2020-03-28 12:21:52 -04:00
mcarlton00
7d9b7dec7d
Merge pull request #249 from TrueTechy/fix-typo
Fixed typo introduced in #215
2020-03-26 14:54:46 -04:00
Abby Gourlay
936f1c6bc6 Fixed typo introduced in #215 2020-03-26 17:59:39 +00:00
Matt
43ee6991cb Remove duplicate strings in translations 2020-03-25 19:16:00 -04:00
Abby
57582d234f
Merge pull request #240 from mcarlton00/follow-redirects
Follow redirects when connecting to server
2020-03-23 00:29:39 +00:00
Matt
3e1884176d Give xml files correct attributes 2020-03-21 19:44:08 -04:00
3788a0b79c
Merge pull request #236 from mcarlton00/ascii-round-two
Fix ascii error on context menu
2020-03-21 18:20:58 +01:00
Matt
0647447c3c Follow redirects when connecting to server 2020-03-21 12:42:25 -04:00
Abby
69bb8bca04
Merge pull request #238 from mcarlton00/delete-artwork
Add ability to delete artwork from database
2020-03-20 23:41:08 +00:00
Matt
05a375d826 Add ability to delete artwork from database 2020-03-19 19:28:49 -04:00
Matt
4de1230cf5 Fix capitalization in boxsets 2020-03-19 18:04:23 -04:00
Matt
6e786a1e6b Use six to get correct string format 2020-03-19 12:37:50 -04:00
Matt
44808f5dd4 Fix ascii error on context menu 2020-03-19 09:37:47 -04:00
mcarlton00
d7364afbf5
Merge pull request #231 from TrueTechy/remove-webservice
Removed web server for image caching
2020-03-18 12:56:31 -04:00
mcarlton00
881c0e947a
Merge pull request #232 from TrueTechy/year-error-handling
Mitigation for #216 for invalid year
2020-03-17 21:33:45 -04:00
Abby Gourlay
9cb0f63749 Left an import in the clipboard 2020-03-18 01:20:22 +00:00
Abby Gourlay
1df9f15859 Resolved suggestions 2020-03-18 01:18:19 +00:00
mcarlton00
a7ef2f6243
Merge pull request #221 from TrueTechy/cleanup-connection-manager
Cleanup connection manager
2020-03-16 09:05:26 -04:00
Abby Gourlay
37a836dd57 Changed function return type 2020-03-16 12:36:06 +00:00
Abby Gourlay
5c93a06e9b Added mitigation for #216 for when the year data from the server is invalid 2020-03-15 01:27:07 +00:00
Abby Gourlay
3bff962cad Removed web server for image caching 2020-03-14 22:37:09 +00:00
Abby Gourlay
a044c1fd29 Fixed API parameter bad optimisation 2020-03-14 21:53:15 +00:00
Abby Gourlay
48ed8ad74c Implemented Suggestions 2020-03-12 22:20:18 +00:00
Abby Gourlay
068a842184 Removed profilling code accidentally commited 2020-03-08 18:08:30 +00:00
Abby Gourlay
36cd765c21 Updated debug logging for sanitising user data 2020-03-08 16:29:15 +00:00
Matt
0cff79e3c8 Fix logic around checking existing video directory 2020-03-07 10:12:49 -05:00
Matt
fcc6e942ab Use correct xml library for kodi 2020-03-07 08:36:30 -05:00
Matt
bb0a539074 Rework xml unicode handling 2020-03-06 23:38:43 -05:00
Abby Gourlay
298c8b6f25 Renamed function for better clarity 2020-03-06 22:57:13 +00:00
Abby
4806379a25
Merge pull request #209 from druscoe/reduce_execute_and_fetch_one_calls
Reduce execute and fetch one calls
2020-02-27 23:30:10 +00:00
Abby
e4a364e3bf
Merge pull request #215 from itsthejoker/library-clarifications
Remove duplicated code and rename UpdatedWorker class
2020-02-27 23:23:59 +00:00
Joe Kaufeld
12a373d030 remove duplicated code and rename UpdatedWorker class
Signed-off-by: Joe Kaufeld <joe@grafeas.org>
2020-02-26 22:49:42 -05:00
Matt
e6101b404a Fix music video scanning 2020-02-26 21:05:38 -05:00
Matt
de95807323 Run library updates properly with current items 2020-02-26 20:59:02 -05:00
Abby
43f0c57ffd
Merge pull request #211 from mcarlton00/once-more-with-feeling
More getitem cleanup in library
2020-02-26 23:07:12 +00:00
Matt
7efc6f9b6a Fix variable names 2020-02-25 20:25:47 -05:00
Matt
1d02fccce6 Prevent harmless errors about bad dates from the server 2020-02-25 20:19:59 -05:00
Matt
4e37aa9bbf Finish getitem cleanup in library 2020-02-25 18:39:50 -05:00
Chuddah
e23d2e1f7b Forgot to remove unexecuted code. 2020-02-23 19:31:41 +00:00
Chuddah
6fe450da4d Attempt number 2 on a larger dataset; the people table.
Note: This has a previously applied optimization of using a local cache.

Before:
```
458570   66.934    0.000   66.934    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
246771   58.075    0.000   58.075    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

After:
```
368883   66.220    0.000   66.220    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
157084   58.160    0.000   58.160    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

Once again, the number of calls to execute and fetchone are reduced but
the total time spent executing each is relatively stable.
2020-02-23 18:27:12 +00:00
Chuddah
0a69894320 Attempt to reduce the number of calls to execute and fetchone.
Profiling has shown that there are many calls to sqlite3.execute and
fetchone which takes a signicant amount of time. A simple way of
reducing these is to swap the 2-stage init of table row data into a
unified add.

Applying this to add_set and add_country yielded these results:

Before changes
```
281784    7.054    0.000    7.054    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
127443    1.114    0.000    1.114    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

After changes
```
281714    7.492    0.000    7.492    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
127373    1.217    0.000    1.217    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

Note: The total time of fetchone has actually increased. I am hoping
this was an abnormality on my machine and the actual reduction in the
number of calls will permantly reduce this total time.
2020-02-23 18:00:38 +00:00
Matt
19ec48cd5b Use six library instead of checking sys version 2020-02-23 00:07:44 -05:00
Matt
5479ba2775 Make commands python 2/3 compatible 2020-02-22 23:23:14 -05:00
mcarlton00
0e4458fa75
Merge pull request #193 from druscoe/inefficeint_usage_of_json_dumps_in_debug_output
Replaced debug output of json.dumps with an indirection to lazy __str__.
2020-02-22 14:50:49 -05:00
Chuddah
de493d13dd Moved JsonDebugPrinter to existing utils module 2020-02-22 15:04:28 +00:00
mcarlton00
4d4f45cd42
Merge pull request #202 from druscoe/threaded_http_gets
Parallelize multiple http GETs
2020-02-20 20:12:29 -05:00
Abby Gourlay
e5cde15ad2 Added a missing file 2020-02-21 00:50:32 +00:00
Abby Gourlay
417b9fb938 Recreated Branch 2020-02-21 00:42:50 +00:00
mcarlton00
2fbdd191d5
Merge pull request #201 from druscoe/in_progress_ui_updates
Allow for UI updates as the library is being sync'ed
2020-02-20 19:20:07 -05:00
Damien Ruscoe
756991e9ec
Resort to the expensive database lookup only if the person exists in the (#200)
* Added profiling info

* Resort to the expensive database lookup only if the person exists in the
database.

* Prevent any access to the people database unless a person must be added.

* Bulk operations where possible.

* Prepare for a new install and the table not existing.
2020-02-19 19:28:47 -05:00