From fd93723968782430703f4c4d4c608a9f523db66c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Chv=C3=ADla?= Date: Wed, 28 Oct 2020 11:43:47 +0100 Subject: [PATCH] playutils: Honor EnableSubtitleExtraction server option * fix bug where subtitle streams that don't support external streaming would show up in video player OSD selection as external when transcoding (e.g. embedded PGSSUB) * fix bug where EnableSubtitleExtraction server setting wasn't taken into consideration when transcoding --- jellyfin_kodi/helper/playutils.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/jellyfin_kodi/helper/playutils.py b/jellyfin_kodi/helper/playutils.py index 4b85bc37..2f0e2a58 100644 --- a/jellyfin_kodi/helper/playutils.py +++ b/jellyfin_kodi/helper/playutils.py @@ -509,8 +509,13 @@ class PlayUtils(object): mapping = {} kodi = 0 + server_settings = TheVoid('GetTranscodeOptions', {'ServerId': self.info['ServerId']}).get() + for stream in source['MediaStreams']: - if stream['Type'] == 'Subtitle' and stream['DeliveryMethod'] == 'External': + if stream['SupportsExternalStream'] and stream['Type'] == 'Subtitle' and stream['DeliveryMethod'] == 'External': + if not stream['IsExternal'] and not server_settings['EnableSubtitleExtraction']: + continue + index = stream['Index'] url = self.get_subtitles(source, stream, index)