From 80f57983f1344ff4d8c695738f7007d6803c5ca3 Mon Sep 17 00:00:00 2001 From: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com> Date: Mon, 11 Oct 2021 22:57:30 +0200 Subject: [PATCH 1/2] fix incorrect test branch checkout --- .github/workflows/test.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 2c9f9052..d57ff85b 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -4,13 +4,16 @@ on: push: branches: - master - pull_request_target: + pull_request: branches: - master env: PR_TRIGGERED: ${{ github.event_name == 'pull_request' && github.repository == 'jellyfin/jellyfin-kodi' }} +permissions: + checks: write + jobs: test: runs-on: ubuntu-latest @@ -55,7 +58,7 @@ jobs: - name: Run reviewdog for PR checks-api if: ${{ env.PR_TRIGGERED == 'true' && matrix.py_version == '3.9' }} env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.JF_BOT_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | cat flake8.output | reviewdog -reporter=github-pr-check -f=flake8 -name="flake8" From 74ce3d88dbebd010f83373d79205055848b5af44 Mon Sep 17 00:00:00 2001 From: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com> Date: Mon, 11 Oct 2021 23:17:56 +0200 Subject: [PATCH 2/2] remove reviewdog --- .github/workflows/test.yaml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index d57ff85b..af789e67 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -11,9 +11,6 @@ on: env: PR_TRIGGERED: ${{ github.event_name == 'pull_request' && github.repository == 'jellyfin/jellyfin-kodi' }} -permissions: - checks: write - jobs: test: runs-on: ubuntu-latest @@ -30,12 +27,6 @@ jobs: with: python-version: ${{ matrix.py_version }} - - name: Setup reviewdog - uses: reviewdog/action-setup@v1 - if: ${{ env.PR_TRIGGERED == 'true' && matrix.py_version == '3.9' }} - with: - reviewdog_version: nightly - - name: Install dependencies run: | python -m pip install --upgrade pip @@ -55,13 +46,6 @@ jobs: coverage xml coverage report - - name: Run reviewdog for PR checks-api - if: ${{ env.PR_TRIGGERED == 'true' && matrix.py_version == '3.9' }} - env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - cat flake8.output | reviewdog -reporter=github-pr-check -f=flake8 -name="flake8" - - name: Upload coverage uses: codecov/codecov-action@v2.1.0 if: ${{ matrix.py_version == '3.9' }}