Merge pull request #94 from oddstr13/pr-address-normalize-1

Improve address normalization in connection manager

resources/lib/jellyfin/core/connection_manager.py

@@ -4,12 +4,13 @@
 
 import json
 import logging
-import hashlib
 import socket
 import time
 from datetime import datetime
 from distutils.version import LooseVersion
 
+import urllib3
+
 from credentials import Credentials
 from http import HTTP
 
@@ -109,7 +110,7 @@ class ConnectionManager(object):
 
         if not server:
             raise AttributeError("server cannot be empty")
-            
+
         try:
             request = {
                 'type': "POST",
@@ -134,6 +135,8 @@ class ConnectionManager(object):
         if not address:
             return False
 
+        address = self._normalize_address(address)
+
         def _on_fail():
             LOG.error("connectToAddress %s failed", address)
             return self._resolve_failure()
@@ -470,13 +473,18 @@ class ConnectionManager(object):
 
     def _normalize_address(self, address):
         # Attempt to correct bad input
-        address = address.strip()
-        address = address.lower()
+        url = urllib3.util.parse_url(address.strip())
 
-        if 'http' not in address:
-            address = "http://%s" % address
+        if url.scheme is None:
+            url = url._replace(scheme='http')
 
-        return address
+        if url.scheme == 'http' and url.port == 80:
+            url = url._replace(port=None)
+
+        if url.scheme == 'https' and url.port == 443:
+            url = url._replace(port=None)
+
+        return url.url
 
     def _save_user_info_into_credentials(self, server, user):