Merge pull request #209 from libanp/develop

Fix version checks

resources/lib/helper/utils.py

@@ -10,6 +10,7 @@ import re
 import unicodedata
 import urllib
 from uuid import uuid4
+from distutils.version import LooseVersion
 
 import xbmc
 import xbmcaddon
@@ -95,25 +96,14 @@ def compare_version(a, b):
         1 a is larger
         0 equal
     '''
-    a = a.split('.')
+    a = LooseVersion(a)
-    b = b.split('.')
+    b = LooseVersion(b)
 
-    for i in range(0, max(len(a), len(b)), 1):
+    if a < b:
-        try:
+        return -1
-            aVal = a[i]
-        except IndexError:
-            aVal = 0
 
-        try:    
+    if a > b:
-            bVal = b[i]
+        return 1
-        except IndexError:
-            bVal = 0
-
-        if aVal < bVal:
-            return -1
-
-        if aVal > bVal:
-            return 1
 
     return 0
 

resources/lib/jellyfin/core/connection_manager.py

@@ -8,6 +8,7 @@ import hashlib
 import socket
 import time
 from datetime import datetime
+from distutils.version import LooseVersion
 
 from credentials import Credentials
 from http import HTTP
@@ -394,25 +395,14 @@ class ConnectionManager(object):
             1 a is larger
             0 equal
         '''
-        a = a.split('.')
+        a = LooseVersion(a)
-        b = b.split('.')
+        b = LooseVersion(b)
 
-        for i in range(0, max(len(a), len(b)), 1):
+        if a < b:
-            try:
+            return -1
-                aVal = a[i]
-            except IndexError:
-                aVal = 0
 
-            try:    
+        if a > b:
-                bVal = b[i]
+            return 1
-            except IndexError:
-                bVal = 0
-
-            if aVal < bVal:
-                return -1
-
-            if aVal > bVal:
-                return 1
         
         return 0