From 0ec3741ef8696b6d7abe3f1ddce4908e45207acd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcell=20Kov=C3=A1cs?= Date: Tue, 7 Feb 2023 18:02:24 +0100 Subject: [PATCH] fix grammar --- .github/workflows/test.yaml | 2 +- CONTRIBUTING.md | 2 +- jellyfin_kodi/client.py | 2 +- jellyfin_kodi/downloader.py | 2 +- jellyfin_kodi/full_sync.py | 2 +- jellyfin_kodi/helper/lazylogger.py | 2 +- jellyfin_kodi/helper/playutils.py | 2 +- jellyfin_kodi/jellyfin/client.py | 2 +- jellyfin_kodi/monitor.py | 4 ++-- jellyfin_kodi/views.py | 6 +++--- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 14b85c4b..14192ef9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -50,7 +50,7 @@ jobs: uses: codecov/codecov-action@v3.1.1 if: ${{ matrix.py_version == '3.9' }} - - name: Publish Test Atrifact + - name: Publish Test Artifact uses: actions/upload-artifact@v3 with: retention-days: 14 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 118cdfc9..915f6148 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ # How to contribute -Thanks you for contributing to Jellyfin for Kodi! +Thank you for contributing to Jellyfin for Kodi! * Make pull requests towards the **master** branch; * Keep the maximum line length shorter than 100 characters to keep things clean and readable; diff --git a/jellyfin_kodi/client.py b/jellyfin_kodi/client.py index 0879225d..3aac72cb 100644 --- a/jellyfin_kodi/client.py +++ b/jellyfin_kodi/client.py @@ -58,7 +58,7 @@ def get_device_name(): ''' Detect the device name. If deviceNameOpt, then use the device name in the add-on settings. - Otherwise fallback to the Kodi device name. + Otherwise, fallback to the Kodi device name. ''' if not settings('deviceNameOpt.bool'): device_name = xbmc.getInfoLabel('System.FriendlyName') diff --git a/jellyfin_kodi/downloader.py b/jellyfin_kodi/downloader.py index fa91c398..f9fb03ca 100644 --- a/jellyfin_kodi/downloader.py +++ b/jellyfin_kodi/downloader.py @@ -235,7 +235,7 @@ def _get_items(query, server_id=None): # multiprocessing.dummy.Pool completes all requests in multiple threads but has to # complete all tasks before allowing any results to be processed. ThreadPoolExecutor # allows for completed tasks to be processed while other tasks are completed on other - # threads. Dont be a dummy.Pool, be a ThreadPoolExecutor + # threads. Don't be a dummy.Pool, be a ThreadPoolExecutor with concurrent.futures.ThreadPoolExecutor(dthreads) as p: # dictionary for storing the jobs and their results jobs = {} diff --git a/jellyfin_kodi/full_sync.py b/jellyfin_kodi/full_sync.py index 44af7db5..7463c300 100644 --- a/jellyfin_kodi/full_sync.py +++ b/jellyfin_kodi/full_sync.py @@ -210,7 +210,7 @@ class FullSync(object): def process_library(self, library_id): - ''' Add a library by it's id. Create a node and a playlist whenever appropriate. + ''' Add a library by its id. Create a node and a playlist whenever appropriate. ''' media = { 'movies': self.movies, diff --git a/jellyfin_kodi/helper/lazylogger.py b/jellyfin_kodi/helper/lazylogger.py index c53ddefa..cead1f11 100644 --- a/jellyfin_kodi/helper/lazylogger.py +++ b/jellyfin_kodi/helper/lazylogger.py @@ -4,7 +4,7 @@ from __future__ import division, absolute_import, print_function, unicode_litera class LazyLogger(object): """`helper.loghandler.getLogger()` is used everywhere. - This class helps avoiding import errors. + This class helps to avoid import errors. """ __logger = None __logger_name = None diff --git a/jellyfin_kodi/helper/playutils.py b/jellyfin_kodi/helper/playutils.py index a40e6f2b..6fc850fc 100644 --- a/jellyfin_kodi/helper/playutils.py +++ b/jellyfin_kodi/helper/playutils.py @@ -515,7 +515,7 @@ class PlayUtils(object): def set_external_subs(self, source, listitem): - ''' Try to download external subs locally so we can label them. + ''' Try to download external subs locally, so we can label them. Since Jellyfin returns all possible tracks together, sort them. IsTextSubtitleStream if true, is available to download from server. ''' diff --git a/jellyfin_kodi/jellyfin/client.py b/jellyfin_kodi/jellyfin/client.py index c22397c2..5026a73e 100644 --- a/jellyfin_kodi/jellyfin/client.py +++ b/jellyfin_kodi/jellyfin/client.py @@ -20,7 +20,7 @@ LOG = LazyLogger(__name__) def callback(message, data): - ''' Callback function should received message, data + ''' Callback function should receive message, data message: string data: json dictionary ''' diff --git a/jellyfin_kodi/monitor.py b/jellyfin_kodi/monitor.py index 760425a5..31b9d67c 100644 --- a/jellyfin_kodi/monitor.py +++ b/jellyfin_kodi/monitor.py @@ -77,7 +77,7 @@ class Monitor(xbmc.Monitor): Otherwise the next played item will be added the previous queue. ''' if method == "Player.OnStop": - xbmc.sleep(3000) # let's wait for the player so we don't clear the canceled playlist by mistake. + xbmc.sleep(3000) # let's wait for the player, so we don't clear the canceled playlist by mistake. if xbmc.getCondVisibility("!Player.HasMedia + !Window.IsVisible(busydialog)"): @@ -247,7 +247,7 @@ class Monitor(xbmc.Monitor): elif command == 'SetVolume': xbmc.executebuiltin('SetVolume(%s[,showvolumebar])' % args['Volume']) - # Kodi needs a bit of time to update it's current status + # Kodi needs a bit of time to update its current status xbmc.sleep(500) self.player.report_playback() diff --git a/jellyfin_kodi/views.py b/jellyfin_kodi/views.py index 6ee678b0..8569cb1e 100644 --- a/jellyfin_kodi/views.py +++ b/jellyfin_kodi/views.py @@ -191,7 +191,7 @@ class Views(object): playlist_path = translate_path("special://profile/playlists/video") index = 0 - # Kodi 19 doesn't seem to create this directory on it's own + # Kodi 19 doesn't seem to create this directory on its own if not os.path.isdir(node_path): os.makedirs(node_path) @@ -680,7 +680,7 @@ class Views(object): def window_nodes(self): ''' Just read from the database and populate based on SortedViews - Setup the window properties that reflect the jellyfin server views and more. + Set up the window properties that reflect the jellyfin server views and more. ''' self.window_clear() self.window_clear('Jellyfin.wnodes') @@ -937,7 +937,7 @@ class Views(object): def delete_playlist_by_id(self, view_id): - ''' Remove playlist based based on view_id. + ''' Remove playlist based on view_id. ''' path = translate_path("special://profile/playlists/video/") _, files = xbmcvfs.listdir(path)