From 0a69894320cab7ef58944a382fa5d7d7c31c40d7 Mon Sep 17 00:00:00 2001
From: Chuddah <chuddah@gmail.com>
Date: Sun, 23 Feb 2020 18:00:38 +0000
Subject: [PATCH] Attempt to reduce the number of calls to execute and
 fetchone.

Profiling has shown that there are many calls to sqlite3.execute and
fetchone which takes a signicant amount of time. A simple way of
reducing these is to swap the 2-stage init of table row data into a
unified add.

Applying this to add_set and add_country yielded these results:

Before changes
```
281784    7.054    0.000    7.054    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
127443    1.114    0.000    1.114    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

After changes
```
281714    7.492    0.000    7.492    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
127373    1.217    0.000    1.217    0.000 {method 'fetchone' of 'sqlite3.Cursor' objects}
```

Note: The total time of fetchone has actually increased. I am hoping
this was an abnormality on my machine and the actual reduction in the
number of calls will permantly reduce this total time.
---
 jellyfin_kodi/objects/kodi/movies.py  | 24 ++++--------------------
 jellyfin_kodi/objects/kodi/queries.py | 16 ++++------------
 2 files changed, 8 insertions(+), 32 deletions(-)

diff --git a/jellyfin_kodi/objects/kodi/movies.py b/jellyfin_kodi/objects/kodi/movies.py
index 40c442a1..0515f2e0 100644
--- a/jellyfin_kodi/objects/kodi/movies.py
+++ b/jellyfin_kodi/objects/kodi/movies.py
@@ -37,16 +37,6 @@ class Movies(Kodi):
 
         return self.cursor.fetchone()[0] + 1
 
-    def create_entry_set(self):
-        self.cursor.execute(QU.create_set)
-
-        return self.cursor.fetchone()[0] + 1
-
-    def create_entry_country(self):
-        self.cursor.execute(QU.create_country)
-
-        return self.cursor.fetchone()[0] + 1
-
     def get(self, *args):
 
         try:
@@ -114,11 +104,8 @@ class Movies(Kodi):
             self.cursor.execute(QU.update_country, (self.get_country(country),) + args)
 
     def add_country(self, *args):
-
-        country_id = self.create_entry_country()
-        self.cursor.execute(QU.add_country, (country_id,) + args)
-
-        return country_id
+        self.cursor.execute(QU.add_country, args)
+        return self.cursor.lastrowid
 
     def get_country(self, *args):
 
@@ -130,11 +117,8 @@ class Movies(Kodi):
             return self.add_country(*args)
 
     def add_boxset(self, *args):
-
-        set_id = self.create_entry_set()
-        self.cursor.execute(QU.add_set, (set_id,) + args)
-
-        return set_id
+        self.cursor.execute(QU.add_set, args)
+        return self.cursor.lastrowid
 
     def update_boxset(self, *args):
         self.cursor.execute(QU.update_set, args)
diff --git a/jellyfin_kodi/objects/kodi/queries.py b/jellyfin_kodi/objects/kodi/queries.py
index 60d326b4..a9660c8a 100644
--- a/jellyfin_kodi/objects/kodi/queries.py
+++ b/jellyfin_kodi/objects/kodi/queries.py
@@ -44,14 +44,6 @@ create_movie = """
 SELECT      coalesce(max(idMovie), 0)
 FROM        movie
 """
-create_set = """
-SELECT      coalesce(max(idSet), 0)
-FROM        sets
-"""
-create_country = """
-SELECT      coalesce(max(country_id), 0)
-FROM        country
-"""
 create_musicvideo = """
 SELECT      coalesce(max(idMVideo), 0)
 FROM        musicvideo
@@ -319,12 +311,12 @@ add_unique_id_movie_obj = ["{Unique}", "{MovieId}", "movie", "{UniqueId}", "{Pro
 add_unique_id_tvshow_obj = ["{Unique}", "{ShowId}", "tvshow", "{UniqueId}", "{ProviderName}"]
 add_unique_id_episode_obj = ["{Unique}", "{EpisodeId}", "episode", "{UniqueId}", "{ProviderName}"]
 add_country = """
-INSERT INTO     country(country_id, name)
-VALUES          (?, ?)
+INSERT INTO     country(name)
+VALUES          (?)
 """
 add_set = """
-INSERT INTO     sets(idSet, strSet, strOverview)
-VALUES          (?, ?, ?)
+INSERT INTO     sets(strSet, strOverview)
+VALUES          (?, ?)
 """
 add_set_obj = ["{Title}", "{Overview}"]
 add_musicvideo = """